Windows 10 detection fix #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a manifest indicating Windows 10 support to the Windows gPTP build, so that Windows 10 detection will work correctly. Manifest support is available with CMake 3.4 and later. Also changed ptp_message.cpp to address a x64 compile warning. Note that these changes were only tested with Microsoft Visual Studio Premium 2012 Update 5, and not with any other compilers.
pinealservo
approved these changes
May 7, 2017
There was a problem hiding this comment.
I don't have much skin in the Windows compatibility game, but the changes look fine to me. If you're feeling ambitious, it might be nice to get an account for OpenAvnu at https://www.appveyor.com/ to get automatic Windows CI builds like we get for Linux on Travis CI.
|
Looks ok to me. Merging.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a manifest indicating Windows 10 support to the Windows gPTP build, so that Windows 10 detection will work correctly. Manifest support is available with CMake 3.4 and later.
Also changed ptp_message.cpp to address a x64 compile warning.
Note that these changes were only tested with Microsoft Visual Studio Premium 2012 Update 5, and not with any other compilers.