Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gPTP: Windows: MSVC compile fixes #621

Merged
merged 2 commits into from
Jun 7, 2017

Conversation

andrew-elder
Copy link

No description provided.

@andrew-elder
Copy link
Author

@christopher-s-hall - is this what you were thinking?

@christopher-s-hall
Copy link
Contributor

Yes on the code, but I think we should keep the Intel PCH controller PHY delays. The actual PHY delay is difficult to pin down on these devices and usually involves experimentation, but those numbers are "pretty close" for any recent Intel platforms.

@andrew-elder
Copy link
Author

I copied the delays from the linux build. I noticed the change when updating the #defines. Are the PCH delays different than I210 ones? And are you saying we should default to the non-I210 ones? So that would mean I would revert the #define names for the windows build?

@christopher-s-hall
Copy link
Contributor

The PHY delays are different on the PCH. Please use the PCH ones for the Windows build unless we have an I210 driver for Windows.

@andrew-elder
Copy link
Author

@christopher-s-hall - changes incorporated. Please confirm this is what you were thinking.

@christopher-s-hall
Copy link
Contributor

Looks good to me.

@andrew-elder
Copy link
Author

@bdthomsen - can you please take a minute to review (and hopefully merge). Then I can submit my next pull request!

@bdthomsen bdthomsen merged commit fd432fa into Avnu:open-avb-next Jun 7, 2017
@andrew-elder andrew-elder deleted the gptp_msvc branch June 8, 2017 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants