Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest of fix for gPTP intervals on ARM #646

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

pinealservo
Copy link
Contributor

The previous fix correctly identified the problem but was incomplete--this
one has actually been verified to work. More char fields had to be changed
to signed char to avoid problems with negative numbers.

The previous fix correctly identified the problem but was incomplete--this
one has actually been verified to work. More `char` fields had to be changed
to `signed char` to avoid problems with negative numbers.
@pinealservo
Copy link
Contributor Author

Sorry, my testing procedure for the last patch was flawed; I hadn't removed the command line parameters from the correct launch script, so it launched with command line parameters and worked correctly due to that instead of the incomplete fix. I got the right script edited this time, so I'm pretty sure it's actually working to set the right default parameters now.

The Travis failure is unrelated to the code here; I'm not sure why it's doing that.

@pinealservo
Copy link
Contributor Author

Here's the Travis issue log for the apt repository causing the build fail: https://www.traviscistatus.com/incidents/z1317rvdkbsj

Copy link

@vitorroriz vitorroriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on imx7

@andrew-elder
Copy link

@pinealservo - thanks for the updated commit. @vitorroriz - thanks for testing. Merging.

@andrew-elder
Copy link

Looks like there is something wrong with travis at the moment, but I'm still going to merge this pull request.

@andrew-elder andrew-elder merged commit 179c1ec into Avnu:open-avb-next Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants