Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asi for upstream avb next #88

Merged
merged 110 commits into from
Sep 25, 2014

Conversation

andrew-elder
Copy link

Many changes to MRP implementation.

Andrew Elder and others added 30 commits May 30, 2013 10:17
Previous behavior was for mrpd to emit an error message if an rIn! event was
ever sent to the registrar state machine. This change silently ignores the
rIn! event in the registrar state machine.
Conflicts (resolved):
	daemons/mrpd/mrp.c
	examples/mrp_client/mrpdhelper.c
This commit moves rLA! processing to before vector event processing.
Additionally, LeaveAll is still propagated when num values is 0.
LeaveAll is only applied to attributes having the vector's attribute type.
1) mrp_lvatimer_fsm() explicitly returns tx_request (LVA_TIMER event is the only evt that cares).
2) Add MRP_EVENT_SLA. sLA processing the same as rLA with the exception that mrp_lvatimer_fsm() is not run.
   If mrp_lvatimer_fsm() was run, the lvatimer S/M would transition to PASSIVE and a tx! would then fail
   to set lva.tx.
3) When mrp_lvatimer_fsm() returns tx_request, an sLA event is generated.
4) lva.sdnmsg was never used, so don't set it in mrp_lvatimer_fsm()
5) Add code to support translating !tx to !txLA when LeaveAll is set. Fixes missing domain LVA pdus.
6) change LVATIMER event to emit pdu without waiting for join timer to expire.
7) MSRP: move reset of send_empty_LeaveAll_flag from msrp_emit_domainvectors() to msrp_txpdu()
Andrew Elder and others added 24 commits July 21, 2014 10:53
…e from AskingFailed unless TalkerID is valid.
Renamed typedef structure to avoid a conflict with a member name.
Conflicts:
	daemons/gptp/common/avbts_port.hpp
	daemons/gptp/common/ieee1588.hpp
	daemons/gptp/common/ieee1588clock.cpp
	daemons/gptp/common/ieee1588port.cpp
	daemons/gptp/common/ptp_message.cpp
	daemons/mrpd/mmrp.c
	daemons/mrpd/mrp.c
	daemons/mrpd/mrp.h
	daemons/mrpd/mrpd.c
	daemons/mrpd/msrp.c
	daemons/mrpd/mvrp.c
	examples/mrp_client/mrpValidate.c

Conflicts have been corrected.
This version does not expect both mediaclk and talker streams to be running
from the start of the capture.
@andrew-elder
Copy link
Author

Large pull request awaiting review! Plan will be to leave this up for feedback for about a week.

  • Andrew

@davidcemin
Copy link
Contributor

I read all entries one by one, and left my comments inline. I read most of the code outside git and discussed with Andrew already. From my point of view, this pull request can be merged. It would be good though to have someone else also reviewing it.

andrew-elder pushed a commit that referenced this pull request Sep 25, 2014
@andrew-elder andrew-elder merged commit 12ab541 into Avnu:open-avb-next Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants