Refactor memory two test. #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
approved these changes
May 30, 2017
marcharper
reviewed
May 31, 2017
| actions = [(C, D), (D, D)] | ||
| self.versus_test(opponent=axelrod.Defector(), expected_actions=actions, | ||
| attrs={"play_as": "TFT", "shift_counter": 1, | ||
| "alld_counter": 0}) | ||
| # TFTT if C, D and D, C |
There was a problem hiding this comment.
Are we still testing both possible TFTT cases?
There was a problem hiding this comment.
I'll double check 👍🙂
There was a problem hiding this comment.
I've just checked by removing each case and the test fails so this test is hitting both of them. 👍
Addresses #884.
drvinceknight
force-pushed
the
884-memorytwo
branch
from
967e45d
to
28c5736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #884.
Some of the test cases were not reproducible (they relied on impossible histories) but what I've got there does test everything (I believe!) and I'm also now carefully checking the attributes.