Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Strategy: Implementation of Adaptor #1215

Merged
merged 4 commits into from
Oct 31, 2018
Merged

New Strategy: Implementation of Adaptor #1215

merged 4 commits into from
Oct 31, 2018

Conversation

marcharper
Copy link
Member

@marcharper marcharper commented Oct 29, 2018

Implements two strategies from this paper

@drvinceknight
Copy link
Member

@marcharper not entirely sure how/why it's failing the unit test (something stochastic) and also looks like coverage is missing line 40 of adaptor.py. (Could you also rebase on to master as #1212 is now in.)

@drvinceknight
Copy link
Member

See #1217 re my rebase request.

@marcharper
Copy link
Member Author

Rebased to before prompt-toolkit changes, we can rebase onto something else before merge.

axelrod/game.py Show resolved Hide resolved
axelrod/strategies/adaptor.py Show resolved Hide resolved
derived from the state.

Parameters
----------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ----... need to be omitted for strategy docstrings (our setup can't handle them).

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Interesting that such a "simple" strategy still does not give reproducible results....

@meatballs meatballs merged commit 1a7688b into master Oct 31, 2018
@meatballs meatballs deleted the adaptor branch October 31, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants