-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub actions #1309
Move to GitHub actions #1309
Conversation
f5b202a
to
d6a7819
Compare
Note that I've removed hypothesis from the requirements. As is, to pip install axelrod also installs hypothesis which is silly.
d6a7819
to
b940b39
Compare
1fdd592
to
386f4cd
Compare
0c2e5dd
to
2bf4699
Compare
This is ready to be merged now. All the work is really done in 3 commits:
All the other commits are just testing that the CI reports failures correctly. If you look through the sequence of commits they all check that GitHub actions reports the required failure and then once the corresponding commit is reverted it passes. The red cross on a reverted commit is just because appveyor's PR build wasn't keeping up (and pulling my latest commit which usually had an expected failure) with my sequences of commits (as it was taking too long I didn't wait). You can check that all the builds behaved as expected by clicking on the red cross next to a commit. For example, for 46bf990 (Subject: Revert "Add an error so docs do not build." ): Appveyor To remove appveyor I need to do more than just delete Once this is in I'll also open a few more issues with other things we can do (for example adding The README You can view the README here: https://github.com/Axelrod-Python/Axelrod/blob/5f080503467c6c1158d2c54619445f8e3759e851/README.rst clicking on the CI badge takes you to the GitHub actions page. @marcharper suggested we could have a 100% coverage sticker, but can we do that in a separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Everything looks good to me as well!
We should just remember to open these issues 👍 |
Check that can be imported from another directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piece of work!
No description provided.