Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub actions #1309

Merged
merged 21 commits into from
Apr 8, 2020
Merged

Move to GitHub actions #1309

merged 21 commits into from
Apr 8, 2020

Conversation

drvinceknight
Copy link
Member

No description provided.

@drvinceknight drvinceknight force-pushed the move-to-github-actions branch 2 times, most recently from f5b202a to d6a7819 Compare April 6, 2020 15:17
Note that I've removed hypothesis from the requirements. As is, to pip
install axelrod also installs hypothesis which is silly.
@drvinceknight drvinceknight changed the title Move to GitHub actions WIP: Move to GitHub actions Apr 6, 2020
@drvinceknight
Copy link
Member Author

drvinceknight commented Apr 7, 2020

This is ready to be merged now.

All the work is really done in 3 commits:

  • b940b39 (Subject: Add github actions and remove travis)
  • dbe8a12 (Subject: Report coverage separately.)
  • 5f08050 (Subject: Remove unnecessary badges.)

All the other commits are just testing that the CI reports failures correctly. If you look through the sequence of commits they all check that GitHub actions reports the required failure and then once the corresponding commit is reverted it passes. The red cross on a reverted commit is just because appveyor's PR build wasn't keeping up (and pulling my latest commit which usually had an expected failure) with my sequences of commits (as it was taking too long I didn't wait). You can check that all the builds behaved as expected by clicking on the red cross next to a commit.

For example, for 46bf990 (Subject: Revert "Add an error so docs do not build." ):

Screenshot 2020-04-07 at 16 40 40

Appveyor

To remove appveyor I need to do more than just delete appveyor.yml, I have to delete the project on the appveyor site. As there are other PRs going I won't do that until this PR is in. Once it is (and we have CI for windows and ubuntu through GitHub actions) then I'll delete the project on the appveyor site and open a PR to remove the appveyor.yml.

Once this is in I'll also open a few more issues with other things we can do (for example adding py3.8 and an OSX run - I tried doing this briefly and small bugs appeared so we can just do it separately).

The README

You can view the README here: https://github.com/Axelrod-Python/Axelrod/blob/5f080503467c6c1158d2c54619445f8e3759e851/README.rst clicking on the CI badge takes you to the GitHub actions page.

@marcharper suggested we could have a 100% coverage sticker, but can we do that in a separate PR?

@drvinceknight drvinceknight changed the title WIP: Move to GitHub actions Move to GitHub actions Apr 7, 2020
Copy link
Member

@marcharper marcharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

.github/workflows/config.yml Show resolved Hide resolved
@Nikoleta-v3
Copy link
Member

Everything looks good to me as well!

Once this is in I'll also open a few more issues with other things we can do (for example adding py3.8 and an OSX run - I tried doing this briefly and small bugs appeared so we can just do it separately).

@marcharper suggested we could have a 100% coverage sticker, but can we do that in a separate PR?

We should just remember to open these issues 👍

@drvinceknight
Copy link
Member Author

drvinceknight commented Apr 8, 2020

f4bd6ab's failure is expected it's essentially checking that it would have caught the bug that #1314 fixes.

Copy link
Member

@meatballs meatballs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of work!

@meatballs meatballs merged commit 4e4b110 into master Apr 8, 2020
@meatballs meatballs deleted the move-to-github-actions branch April 8, 2020 14:07
drvinceknight pushed a commit that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants