Style and Temp file closing warning fix #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what it looks like on master: https://www.dropbox.com/s/9vsr067ag67c445/Screenshot%202016-08-07%2010.07.15.png?dl=0 This is what it looks like with this commit: https://www.dropbox.com/s/xr9ilbp6xeg0t7u/Screenshot%202016-08-07%2010.05.56.png?dl=0
Got this error without it: Configuration error: There is a syntax error in your configuration file: Non-ASCII character '\xe2' in file /home/travis/build/drvinceknight/Axelrod/axelrod/match.py on line 161, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details (match.py, line 161) make: *** [html] Error 1
|
Have opened marcharper#4 with a fix for the sphinx build. |
| @@ -111,6 +111,8 @@ def play(self, build_results=True, filename=None, | |||
| if build_results: | |||
| return self._build_result_set(progress_bar=progress_bar, | |||
| keep_interactions=keep_interactions) | |||
| else: | |||
|
This looks great. Out of curiosity, did you use some automatic thing to do this or did you work through all the files yourself (Herculean effort it that's how you did it!)? 👍 |
Fix the sphinx build error.
|
Just the old fashioned way! |
👍 💪 This PR looks good to me. Nice clean up of things! |
|
@drvinceknight Two more commits, mostly cleaning up unused parameters for the tournament classes. |
|
👍 |
|
(Assuming Travis is happy with the sphinx build.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #681