Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toast): use toasts from context #242

Merged
merged 1 commit into from
Oct 19, 2022
Merged

feat(toast): use toasts from context #242

merged 1 commit into from
Oct 19, 2022

Conversation

danielkaxis
Copy link
Collaborator

@danielkaxis danielkaxis commented Sep 9, 2022 •
edited
Loading

Describe your changes

Enables use of multiple ToastAnchors throughout the application sharing the toasts.
Moves the ToastMap to the ToastProvider

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@danielkaxis danielkaxis changed the title Draft: feat(toast): export ToastAnchor Draft: feat(toast): use toasts from context Sep 13, 2022
@danielkaxis danielkaxis changed the title Draft: feat(toast): use toasts from context feat(toast): use toasts from context Sep 13, 2022
@Tigge Tigge force-pushed the main branch 7 times, most recently from 92874f3 to 4adee08 Compare October 18, 2022 05:51
@danielkaxis
feat(toast): use toasts from context
72acfce 
Enables use of different ToastAnchors
throughout the application sharing the
toasts.
@Tigge Tigge merged commit 37ad7cc into AxisCommunications:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tigge Tigge Tigge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast: Show toast in fullscreen
2 participants
@danielkaxis @Tigge