-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reposition popover on scroll & remove tooltip delayed from screen #260
Reposition popover on scroll & remove tooltip delayed from screen #260
Conversation
Keep popover at anchor element when user is scrolling
I'm wondering about respositioning the popover on scroll. It has a slight studder when scrolling and I'm not sure if we can fix it with the current implementation of how popover positions itself to the anchor element. |
Do tooltips even show up on a touch device? I thought they only showed on hover...? |
Yes, when you touch the element. |
Can you add tests as well? |
96099b1
to
4bdde64
Compare
Will look into it |
Remove tooltip on touch-devices if user scrolls more than 150 pixels.
4bdde64
to
d2c218d
Compare
Tests are added! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
To give better user experience for phone and pad users, reposition popover on scroll event.
Also remove the tooltip when user, on a touch device, scrolled more than 150 pixels.
Issue ticket number and link
Checklist before requesting a review