Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): segments missing while dragging #270

Merged

Conversation

rikteg
Copy link
Collaborator

@rikteg rikteg commented Aug 14, 2023

Describe your changes

The key used by DraggableList should not change key depending on order.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

When using DraggableList, some segments goes missing.

Fixes: AxisCommunications#269
@rikteg rikteg requested a review from Tigge as a code owner August 14, 2023 11:50
@Tigge Tigge merged commit 5e90887 into AxisCommunications:main Aug 18, 2023
5 checks passed
@rikteg rikteg deleted the fix-draggablelist-missing-segments branch August 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing segements in DraggableList
2 participants