Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure refresh of permits on subscription query #85

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Ensure refresh of permits on subscription query #85

merged 3 commits into from
Jul 14, 2021

Conversation

abuijze
Copy link
Contributor

@abuijze abuijze commented Jul 14, 2021

Solves an issue where permits weren't properly refreshed when receiving subscription query instructions.

@abuijze
Ensure refresh of permits on subscription query
20aa5c5 
Solves an issue where permits weren't properly refreshed when receiving subscription query instructions.
@abuijze abuijze added this to the Release 4.5.2 milestone Jul 14, 2021
@abuijze abuijze requested review from MGathier and smcvb July 14, 2021 08:34
smcvb
smcvb requested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming a test variable (the for-loop) isn't correct. AFAIK, that means the default number of permits (which is 5000 if I am correct) wouldn't be hit by the test.

src/test/java/io/axoniq/axonserver/connector/query/QueryChannelIntegrationTest.java Show resolved Hide resolved
src/test/java/io/axoniq/axonserver/connector/query/QueryChannelIntegrationTest.java Outdated Show resolved Hide resolved
src/main/java/io/axoniq/axonserver/connector/query/impl/QueryChannelImpl.java Show resolved Hide resolved
smcvb
smcvb approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence approving.

@abuijze abuijze merged commit bebaad2 into connector-4.5.x Jul 14, 2021
@abuijze abuijze deleted the fix-subscription-query-timeout branch July 14, 2021 09:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.7% 0.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@MGathier MGathier MGathier approved these changes

Assignees

@abuijze abuijze

Labels
Priority 1: Must Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 4.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@abuijze @smcvb @MGathier