Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring 409 errors in second attempt of creating api access #531

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

gcornacchia
Copy link
Contributor

in APIManagerAPIAccessAdapter during the creation of API Access if the server returns 409 status code (resource already exists) apim-cli intentionally ignores this error as the API access is already present.

If a retry is triggered due to "unknown API" error, the same check on 409 is not implemented.

This pull request aims to fix this situation.

@gcornacchia gcornacchia requested a review from a team as a code owner January 8, 2025 16:47
@gcornacchia
Copy link
Contributor Author

@rathnapandi

@rathnapandi rathnapandi merged commit c047997 into Axway-API-Management-Plus:develop Jan 8, 2025
1 check failed
@gcornacchia
Copy link
Contributor Author

hi @rathnapandi,
when are you planning to release the next version including this PR?

@rathnapandi
Copy link
Member

Hi @gcornacchia,

I am planning to do a release at the end of next week.

@gcornacchia
Copy link
Contributor Author

hi @rathnapandi, we need to test the next release, when will it be available?

@rathnapandi
Copy link
Member

Hi @gcornacchia,

I am in the process of including one more fix.

Can you please test your fix and confirm -
axway-apimcli-1.14.9-SNAPSHOT.tar.gz

@gcornacchia
Copy link
Contributor Author

gcornacchia commented Jan 23, 2025

Unfortunately, my fix wants to address a bug we found when upgrading from 1.14.2 to 1.14.6 and it's not easily reproducible.
If you have visibility you can check this Axway support case https://support.axway.com/en/case-center/view/id/01671223 with all the details.
@rathnapandi

@rathnapandi
Copy link
Member

@gcornacchia,

The fix won't harm anything. I am done with my changes for the release, I will make sure all integration test passes and do the release tomorrow.

@rathnapandi
Copy link
Member

Hi @gcornacchia,
I am facing the issue of publishing jar files to Maven repository (it is getting timed out). I will try again on Monday,

@rathnapandi
Copy link
Member

Hi @gcornacchia,

I have published the release, please test, and let me know if you run into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants