Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications: add setter to frequency #124

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Applications: add setter to frequency #124

merged 1 commit into from
Oct 12, 2023

Conversation

matt1432
Copy link
Contributor

I wanted to have a setter for frequency to be able to launch apps from the applauncher without using the launch() function, while still having the benefit of keeping track of frequency.

I wasn't satisfied with the resolution of #50, so this is my take on it.

Basically, instead of doing app.launch(), I do this:

Utils.exec(`hyprctl dispatch exec ${app.executable}`);
++app.frequency;

@Aylur Aylur merged commit a3cfe8c into Aylur:main Oct 12, 2023
1 check passed
@kotontrion
Copy link
Contributor

I know this got already merged, but I don't like that the launched signal is emitted when setting the frequency. Wouldn't this result in emitting the signal twice when using the launch method?

@Aylur
Copy link
Owner

Aylur commented Oct 13, 2023

the launch method increments the internal value and not through the setter

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants