Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow layer click-through #245

Merged
merged 7 commits into from
Jan 14, 2024
Merged

Allow layer click-through #245

merged 7 commits into from
Jan 14, 2024

Conversation

end-4
Copy link
Contributor

@end-4 end-4 commented Jan 8, 2024

About this PR

Added "clickthrough" boolean property. Makes an AgsWindow not block mouse input for windows below if set to true
Example:

  • Screen corners in Aylur's setup or my setup would benefit from not being clickable. I think this image explains it
    image

Does it need extra work?

Yes
I've only figured out how to make clickthrough work
I haven't made it work the other way round and the getter func, and I'd really appreciate pointers on how to do these.

Reference

@end-4 end-4 marked this pull request as draft January 8, 2024 15:54
@end-4 end-4 marked this pull request as ready for review January 9, 2024 12:25
@end-4
Copy link
Contributor Author

end-4 commented Jan 9, 2024

Currently, we can get the prop and set it to true, but not to false.
I can't find any docs, and I'm not sure if this is even possible in GJS.
I'll let @Aylur decide whether this is acceptable or not.

@Aylur Aylur merged commit acb9fa5 into Aylur:main Jan 14, 2024
2 checks passed
gorsbart pushed a commit to gorsbart/ags that referenced this pull request Feb 28, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants