fixup(notifd): make dismissed signal internal

its used only internally, the resolved signal is meant to be the public api
Aylur · Oct 29, 2024 · 479e85a · 479e85a
1 parent 8705ab4
commit 479e85a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/lib/notifd/notification.vala b/lib/notifd/notification.vala
@@ -158,12 +158,6 @@ public class AstalNotifd.Notification : Object {
      */
     public signal void resolved(ClosedReason reason);
 
-    /**
-     * Emitted when the user dismisses this notification.
-     *
-     * @see dismiss
-     */
-    public signal void dismissed();
 
     /**
      * Emitted when an [struct@AstalNotifd.Action] of this notification is invoked.
@@ -173,12 +167,10 @@ public class AstalNotifd.Notification : Object {
     public signal void invoked(string action_id);
 
     /**
-     * Dismiss this notification popup
-     *
-     * This method doesn't have any functionality on its own, but should be handled
-     * by frontend implementation to hide notification popups.
+     * Resolve this notification with [enum@AstalNotifd.ClosedReason.DISMISSED_BY_USER].
      */
     public void dismiss() { dismissed(); }
+    internal signal void dismissed();
 
     /**
      * Invoke an [struct@AstalNotifd.Action] of this notification.

diff --git a/lib/notifd/proxy.vala b/lib/notifd/proxy.vala
@@ -32,10 +32,6 @@ internal class AstalNotifd.DaemonProxy : Object {
         set { proxy.dont_disturb = value; }
     }
 
-    public uint[] notification_ids() throws DBusError, IOError {
-        return proxy.notification_ids();
-    }
-
     public Notification get_notification(uint id) {
         return notifs.get(id);
     }

diff --git a/lib/notifd/signals.md b/lib/notifd/signals.md
@@ -5,7 +5,7 @@ ignore this, I'm just dumb and can't follow where signals go or get emitted from
 ## Notification
 
 * resolved(reason) - by daemon/proxy
-* dismissed() - by user with `.dismiss()`
+* dismissed() - by user with `.dismiss()`, used to emit resolved from proxy/daemon
 * invoked(action) - by user with `.invoke()`
 
 ## Deamon