Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget results improvements #849

Merged
merged 3 commits into from
Jul 12, 2017
Merged

Conversation

bertocq
Copy link

@bertocq bertocq commented Jul 12, 2017

Where

  • Related Issue:

What

1- Custom translated route for results resultados
2- Link between Stats and Results pages with custom routes resultados and estadisticas
3- Make Results current heading active
4- Order Results headings by id (make "All city" be the first heading on results page)

How

  • Adding a new named custom route for results
  • Adding missing tab links on both stats and results pages (making sure the Results tab on Stats page only shows when Budget is on Finished status) for everything else the Abilities take care
  • Check the current heading from the params (using slugs, instead of id's as consul still behind on that)
  • Order by id ASC, as we know for now its enough to make "Toda la ciudad" appear as first heading.

Screenshots

Results link on Stats page:

screen shot 2017-07-12 at 12 44 06

Stats link on Results page, plus current heading shown as active:

screen shot 2017-07-12 at 12 44 02

Test

  • I think updated, but lets see travis

Deployment

  • As usual

Warnings

  • Many of this changes should be ported back to consul

@bertocq bertocq merged commit 2e31920 into master Jul 12, 2017
@bertocq bertocq deleted the feature/budget_results_improvements branch July 12, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants