Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Budget results urls #850

Merged
merged 17 commits into from
Jul 13, 2017
Merged

Budget results urls #850

merged 17 commits into from
Jul 13, 2017

Conversation

voodoorai2000
Copy link
Member

What

  • Adds custom budget heading result's path
    /presupuestos-participativos-2017/resultados/arganzuela
  • Marks first heading as selected when going to
    /presupuestos-participativos-2017/resultados

How

  • Adding a custom route for heading results
  • Using an instance variable instead of params to know what is the current heading

Screenshots

  • Custom heading route
    url

  • Mark first heading as selected
    first heading selected

bertocq
bertocq approved these changes Jul 12, 2017
View reviewed changes
Copy link

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@voodoorai2000 voodoorai2000 mentioned this pull request Jul 12, 2017
Closed
4 tasks
@bertocq bertocq force-pushed the budget-results-urls branch from 29cea9c to 0807c77 Compare July 12, 2017 16:42
@bertocq bertocq force-pushed the budget-results-urls branch from b5c46cb to 0edfcbf Compare July 12, 2017 17:55
@bertocq bertocq force-pushed the budget-results-urls branch from 0edfcbf to 28a0094 Compare July 12, 2017 18:02
@bertocq bertocq merged commit 705e511 into master Jul 13, 2017
@bertocq bertocq deleted the budget-results-urls branch July 13, 2017 09:12
@bertocq bertocq mentioned this pull request Jul 13, 2017
Merged
@javierm javierm mentioned this pull request Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voodoorai2000 @bertocq @decabeza