Skip to content

Commit

Permalink
fix: use correct size for databus_id (#10673)
Browse files Browse the repository at this point in the history
Apparently at the time the below issue was created things failed if we
used the correct limited size for the databus_id poly. Maybe we made a
mistake then or maybe something got fixed somewhere but either way it
works fine now.

Closes AztecProtocol/barretenberg#1107
  • Loading branch information
ledwards2225 authored Dec 13, 2024
1 parent 37e1999 commit 95eb658
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,7 @@ template <IsUltraFlavor Flavor> class DeciderProvingKey_ {
proving_key.polynomials.return_data_read_tags =
Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);

// TODO(https://github.com/AztecProtocol/barretenberg/issues/1107): Restricting databus_id to
// databus_size leads to failure.
// const size_t databus_size = std::max({ calldata.size(), secondary_calldata.size(),
// return_data.size() });
proving_key.polynomials.databus_id = Polynomial(proving_key.circuit_size, proving_key.circuit_size);
proving_key.polynomials.databus_id = Polynomial(MAX_DATABUS_SIZE, proving_key.circuit_size);
}
const size_t max_tables_size =
std::min(static_cast<size_t>(MAX_LOOKUP_TABLES_SIZE), dyadic_circuit_size - 1);
Expand Down

1 comment on commit 95eb658

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 95eb658 Previous: a437e73 Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20 4964.687263999991 ms/iter 4527.275996000015 ms/iter 1.10
Goblin::merge(t) 142325698 ns/iter 132249560 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.