Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devops): release please for release branch #10160

Closed
just-mitch opened this issue Nov 22, 2024 · 0 comments · Fixed by #10467
Closed

feat(devops): release please for release branch #10160

just-mitch opened this issue Nov 22, 2024 · 0 comments · Fixed by #10467
Assignees
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@just-mitch
Copy link
Collaborator

We keep the existing release cycle (release please branches into master) w.r.t. docker images, npm, etc.

  • This is targeted at users who want the latest/greatest but potentially unstable code

At the end of ADT sprints, we merge a regular release into master, e.g. v0.64.0

We cut our release/<adjective>-<animal> from that commit.

Suppose the current release is Sassy Salamander.

We create a release please PR for release/sassy-salamander.

We run our tests on release/sassy-salamander.

If our tests do not pass, we merge a fix into release/sassy-salamander.

When things pass, we merge the release please PR on release/sassy-salamander, which does a normal npm/docker release, and tags (devnet, sassy-salamander).

If there were no hotfixes, then this simply moves the tags forward to v0.64.0, otherwise, it releases v0.64.X (and moves the tags).

@just-mitch just-mitch added the A-devops Area: Devops. E.g. CI / build systems label Nov 22, 2024
@ludamad ludamad assigned spypsy and unassigned ludamad Nov 27, 2024
@just-mitch just-mitch assigned just-mitch and unassigned spypsy Dec 5, 2024
@just-mitch just-mitch linked a pull request Dec 6, 2024 that will close this issue
just-mitch added a commit that referenced this issue Dec 6, 2024
Allows us to have release please PRs for our `release/*` branches. 

When we merge one of the release please PRs on a `release/*` branch
(e.g. `release/sassy-salamander`), the following happens:

- We create new images in dockerhub at e.g.
`aztecprotocol/aztec:sassy-salamander`
- We bump the `devnet` images in dockerhub at e.g.
`aztecprotocol/aztec:devnet`
- We create a regular (semantic versioned) npm release but tagged
`devnet` (as opposed to `latest`)
- We publish aztec-up to version `sassy-salamander`

All other existing publishing flows are unchanged.

Note: this implies that *before* merging the release PR, we have
deployed a new devnet, and the public `sassy-salamander` network.

Note: The
[issue](#10160)
states that if there are no changes between the `sassy-salamander`
branch and `master`, it will simply move tags forward. This does *not*
accomplish that. If that is really desired we should create a separate
ticket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants