Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of contract calls & enqueued calls to unique contracts #10369

Closed
Tracked by #9060
dbanks12 opened this issue Dec 3, 2024 · 1 comment · Fixed by #10640
Closed
Tracked by #9060

Limit number of contract calls & enqueued calls to unique contracts #10369

dbanks12 opened this issue Dec 3, 2024 · 1 comment · Fixed by #10640
Assignees

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Dec 3, 2024

No description provided.

@dbanks12
Copy link
Collaborator Author

dbanks12 commented Dec 5, 2024

Discuss with @IlyasRidhuan

@dbanks12 dbanks12 assigned IlyasRidhuan and unassigned jeanmon Dec 18, 2024
dbanks12 added a commit that referenced this issue Dec 23, 2024
Resolves #10369

Note from @dbanks12:
Once the limit has been reached for contract calls to unique class IDs,
you can still call repeat contract addresses or even other contract
addresses that reuse an already checked class ID.

I had to change the call-ptr/space-id to just use a counter instead of
clk because space-id is uint8 and we were getting collisions.

Follow-up work:
- constrain that user-called address can be derived from the hinted
class ID & instance

---------

Co-authored-by: dbanks12 <david@aztecprotocol.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Dec 24, 2024
Resolves AztecProtocol/aztec-packages#10369

Note from @dbanks12:
Once the limit has been reached for contract calls to unique class IDs,
you can still call repeat contract addresses or even other contract
addresses that reuse an already checked class ID.

I had to change the call-ptr/space-id to just use a counter instead of
clk because space-id is uint8 and we were getting collisions.

Follow-up work:
- constrain that user-called address can be derived from the hinted
class ID & instance

---------

Co-authored-by: dbanks12 <david@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants