Removing a debug log breaks circuit #10558
Labels
A-security
Area: Relates to security. Something is insecure.
Comments
iAmMichaelConnor
added
the
A-security
|
@iAmMichaelConnor does this end up failing inside noir or in external code? if you can get this to fail inside of noir then we can mock the oracle calls which will make it much easier to debug. |
iAmMichaelConnor
added a commit
that referenced
this issue
Dec 10, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - #10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - #10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
|
It's failing inside noir, iiuc. |
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Dec 11, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - AztecProtocol/aztec-packages#10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - AztecProtocol/aztec-packages#10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
lucasxia01
pushed a commit
that referenced
this issue
Dec 11, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - #10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - #10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
spalladino
added a commit
that referenced
this issue
Jan 6, 2025
Hides the log message 'Context.note_hashes, after pushing new note hash' in the oracle. Note we cannot just remove it due to #10558.
spalladino
added a commit
that referenced
this issue
Jan 6, 2025
Hides the log message `Context.note_hashes, after pushing new note hash` in the oracle. Note we cannot just remove it due to #10558 https://github.com/AztecProtocol/aztec-packages/blob/f35094fd74f28d5bb41084f7b89f961a5f4d0af0/noir-projects/aztec-nr/aztec/src/context/private_context.nr#L143-L147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was identified on branch #10486, which is soon to be merged into master.
Possibly related to this: noir-lang/noir#5771
https://aztecprotocol.slack.com/archives/C04PUD9AA4W/p1733747881614369
Commands, for future reference:
Start the txe:
cd yarn-project/txeLOG_LEVEL=debug yarn startWait 5 seconds.
Run the test:
cd ../noir-projects/noir-contracts(Update the local path to be yours in the command below:)
NARGO_FOREIGN_CALL_TIMEOUT=300000 /mnt/user-data/mike/aztec-packages/noir/noir-repo/target/release/nargo test --silence-warnings --oracle-resolver http://localhost:8080 --show-output --package nft_contract transfer_in_private_on_behalf_of_other(And if you want to make quick changes to just the NFT contract, or its dependencies, you can run
./scripts/bootstrap_just_one_contract.sh nft_contract NFTto get the codebase ready for another test run)(Some other NFT tests would also fail, without the debug log).
The text was updated successfully, but these errors were encountered: