Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert when create_hash_and_nullifier function is missing #1303

Closed
Tracked by #1115
spalladino opened this issue Jul 31, 2023 · 0 comments · Fixed by #1364
Closed
Tracked by #1115

Alert when create_hash_and_nullifier function is missing #1303

spalladino opened this issue Jul 31, 2023 · 0 comments · Fixed by #1364
Assignees

Comments

@spalladino
Copy link
Collaborator

spalladino commented Jul 31, 2023

If a contract that creates notes does not implement this function, there is no error surfaced but the notes are just not there when queried. We should alert (emit a warning?) when processing notes that create_hash_and_nullifier is missing. If possible, we should also alert when building the contract, though this may be more difficult to do since we'd need to figure out if a contract is ever creating a note.

Edit: I was wrong on the above, there's currently an error being thrown, that breaks note processing. However, we should not stop processing notes due to the missing function, and log a warning instead.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 31, 2023
@benesjan benesjan self-assigned this Aug 2, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Aug 2, 2023
@benesjan benesjan moved this from In Progress to In Review in A3 Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 2, 2023
benesjan added a commit that referenced this issue Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants