Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper packages version when publishing Sandbox to docker hub #1892

Closed
spalladino opened this issue Aug 30, 2023 · 0 comments · Fixed by #1914
Closed

Set proper packages version when publishing Sandbox to docker hub #1892

spalladino opened this issue Aug 30, 2023 · 0 comments · Fixed by #1914
Assignees
@spypsy
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@spalladino
Copy link
Collaborator

spalladino commented Aug 30, 2023 •
edited
Loading

We are currently publishing the Sandbox and all its dependent Aztec packages with their default 0.1.0 version, instead of setting the actual tag as the version, which we do only for npm publishing. We should also do this for publishing to dockerhub.

Revert #1894 when implementing this.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 30, 2023
@spalladino spalladino added this to the 📢 Initial Public Sandbox Release milestone Aug 30, 2023
@spalladino spalladino mentioned this issue Aug 30, 2023
Merged
spalladino added a commit that referenced this issue Aug 30, 2023
@spalladino
fix: Do not warn on mismatched cli/sandbox version (#1894)
a44a0f6 
Due to #1892, the check implemented in #1849 always fails when run
against the Sandbox docker image. This PR disables it temporarily.
@spypsy spypsy self-assigned this Aug 31, 2023
@spypsy spypsy moved this from Todo to In Progress in A3 Aug 31, 2023
@iAmMichaelConnor iAmMichaelConnor added the A-devops Area: Devops. E.g. CI / build systems label Aug 31, 2023
@spypsy spypsy mentioned this issue Aug 31, 2023
Merged
4 tasks
@spypsy spypsy moved this from In Progress to In Review in A3 Sep 1, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Sep 5, 2023
spypsy added a commit that referenced this issue Sep 5, 2023
@spypsy
fix: Set correct version of RPC & Sandbox when deploying tagged commit (
898c50d 
#1914)

fixes #1892 
Also add `get-node-info` command to CLI which fetches the AztecRPC
information via `getNodeInfo()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set correct version of RPC & Sandbox when deploying tagged commit AztecProtocol/aztec-packages
3 participants
@spalladino @spypsy @iAmMichaelConnor