Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarking to barretenberg/acir_tests #6060

Closed
TomAFrench opened this issue Apr 26, 2024 · 0 comments · Fixed by #6155
Closed

Add benchmarking to barretenberg/acir_tests #6060

TomAFrench opened this issue Apr 26, 2024 · 0 comments · Fixed by #6155
Assignees
@TomAFrench

Comments

@TomAFrench
Copy link
Member

As we're shifting users towards using bb directly for proving/verification rather than going through nargo we should be benchmarking directly in barretenberg.

We can look at reusing the existing benchmarking logic in this repository which will give us diffs on proving speed on PRs for free.

https://github.com/noir-lang/zk_bench can then focus on just benchmarking a set of standard circom programs.
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 26, 2024
@TomAFrench TomAFrench added this to Noir Apr 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 26, 2024
@TomAFrench TomAFrench mentioned this issue Apr 26, 2024
Closed
@TomAFrench TomAFrench mentioned this issue May 3, 2024
Merged
@TomAFrench TomAFrench moved this from 📋 Backlog to 🏗 In progress in Noir May 3, 2024
TomAFrench added a commit that referenced this issue May 21, 2024
@TomAFrench @PhilWindle
@ludamad @spalladino
feat: run benchmarks for ACIR proving (#6155)
ebf6fc2 
Resolves #6060 
---------

Co-authored-by: PhilWindle <philip.windle@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: run benchmarks for ACIR proving AztecProtocol/aztec-packages
2 participants
@TomAFrench @guipublic