You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The key registry allows rotating the nullifier key, however, the caching done in the private_context in request_app_nullifier_secret_key means that only one key could be requested within the same call. This means that you cannot spend notes with different nullifier keys during the same call, as the assertions will fail.
I propose that we cache the latest, such that we don't insert repetitive requests, but allow making multiple request to ensure that we properly support key rotation.
To showcase the issue, I think it is useful to create a separate test that is receiving tokens, rotating the key and then receiving more and finally trying to send it all.
Should wait until #6130 is in to properly test with tokens.
LHerskind
changed the title
test(Keys_Incoming): Showcase full nullifier key rotation
test(Keys_Nullifier): Showcase full nullifier key rotation
May 10, 2024
The key registry allows rotating the nullifier key, however, the caching done in the
private_context
inrequest_app_nullifier_secret_key
means that only one key could be requested within the same call. This means that you cannot spend notes with different nullifier keys during the same call, as the assertions will fail.I propose that we cache the latest, such that we don't insert repetitive requests, but allow making multiple request to ensure that we properly support key rotation.
To showcase the issue, I think it is useful to create a separate test that is receiving tokens, rotating the key and then receiving more and finally trying to send it all.
When showcased we can fix it as well.
Addressing this fits well with #6313.
The text was updated successfully, but these errors were encountered: