You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently only support a single key derivation request in a call. This should be altered to ensure that we can make additional request as we are otherwise unable to use notes that have been received before and after a key rotation within the same call.
Example where we encounter this issue:
Alice sends 10 $ to Bob
Bob rotates his keys
Alice sends 5 $ to Bob
Bob wants to spend his 15$
Bob can't because he need to nullify notes with two different npk_m_h specified, and he only have one request 😭
Unclear if we really need the caching or not, if we are to cache, we likely need to just cache the "last" read value, and then need to lookup if different. Could potentially run into issues if the notes are returned as k1 | k2 | k1 | k2 and so on, as we can never use the cache and potentially adds a lot of validation requests. Something that might be totally fine could be to alter the oracle such that it is returning them sorted by the key as well as other values, but that is really annoying when also dealing with applications that might wants their own sorting etc 🤷. Pain.
At the same time, we should update the number of notes and encrypted logs to be similar, as we might otherwise run into issues where we cannot emit enough logs and our transaction will fail.
This should be done after #6215 to avoid to much pain.
The text was updated successfully, but these errors were encountered:
We currently only support a single key derivation request in a call. This should be altered to ensure that we can make additional request as we are otherwise unable to use notes that have been received before and after a key rotation within the same call.
Example where we encounter this issue:
npk_m_h
specified, and he only have one request 😭Unclear if we really need the caching or not, if we are to cache, we likely need to just cache the "last" read value, and then need to lookup if different. Could potentially run into issues if the notes are returned as
k1 | k2 | k1 | k2
and so on, as we can never use the cache and potentially adds a lot of validation requests. Something that might be totally fine could be to alter the oracle such that it is returning them sorted by the key as well as other values, but that is really annoying when also dealing with applications that might wants their own sorting etc 🤷. Pain.At the same time, we should update the number of notes and encrypted logs to be similar, as we might otherwise run into issues where we cannot emit enough logs and our transaction will fail.
This should be done after #6215 to avoid to much pain.
The text was updated successfully, but these errors were encountered: