Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete stray todos #10112

Merged
merged 1 commit into from
Nov 21, 2024
Merged

chore: Delete stray todos #10112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/bb/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ std::string vk_to_json(std::vector<bb::fr> const& data)
return format("[", join(map(rotated, [](auto fr) { return format("\"", fr, "\""); })), "]");
}

// WORKTODO: delete?
std::string honk_vk_to_json(std::vector<bb::fr>& data)
{
return format("[", join(map(data, [](auto fr) { return format("\"", fr, "\""); })), "]");
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/dsl/acir_format/ivc_recursion_constraint.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ TEST_F(IvcRecursionConstraintTest, GenerateVK)
// Construct kernel consisting only of the kernel completion logic
AcirProgram program = construct_mock_kernel_program(ivc.verification_queue, { num_app_public_inputs });
Builder kernel = acir_format::create_kernel_circuit(program.constraints, ivc);
// WORKTODO: this would normally happen in accumulate()
// Note that this would normally happen in accumulate()
kernel.add_pairing_point_accumulator(stdlib::recursion::init_default_agg_obj_indices<Builder>(kernel));

auto proving_key = std::make_shared<DeciderProvingKey_<MegaFlavor>>(kernel, trace_settings);
Expand Down
7 changes: 0 additions & 7 deletions barretenberg/cpp/src/barretenberg/plonk_honk_shared/execution_trace/mega_execution_trace.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,6 @@ class MegaExecutionTraceBlocks : public MegaTraceBlockData<MegaTraceBlock> {
this->overflow.fixed_size = settings.overflow_capacity;
}

// WORKTODO: use or remove
MegaExecutionTraceBlocks(const TraceSettings& settings)
: MegaExecutionTraceBlocks()
{
set_fixed_block_sizes(settings);
}

void compute_offsets(bool is_structured)
{
uint32_t offset = 1; // start at 1 because the 0th row is unused for selectors for Honk
Expand Down
5 changes: 2 additions & 3 deletions barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,8 @@ class CircuitSimulatorBN254 {
static constexpr size_t UINT_LOG2_BASE = 2; // Would be 6 for UltraPlonk
static constexpr size_t DEFAULT_PLOOKUP_RANGE_BITNUM = 1028;

static constexpr size_t num_gates = 0; // WORKTODO: it was dumb to make this static.
// Should agree with what is in circuit builders
static constexpr uint32_t zero_idx = 0; // Ditto?
size_t num_gates = 0;
static constexpr uint32_t zero_idx = 0; // Should agree with what is in circuit builders
std::vector<FF> public_inputs;

void add_pairing_point_accumulator(const PairingPointAccumulatorIndices& proof_element_limbs)
Expand Down
Loading