-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use UltraRollupHonk in rollup #10342
Merged
Merged
Changes from 131 commits
Commits
Show all changes
134 commits
Select commit
Hold shift + click to select a range
744114c
add ultra rollup flows to main
lucasxia01 76d4271
Merge remote-tracking branch 'origin/master' into lx/rollup-flavor-in…
lucasxia01 481cf87
make the evaluation a witness
lucasxia01 11da990
add TODOs
lucasxia01 e713818
fix test
lucasxia01 99d526e
modify honk recursion constraint to handle ipa claim
lucasxia01 18dee52
Merge branch 'lx/rollup-flavor-interfaces' into lx/ipa-in-rollup
lucasxia01 2aaa8f1
change rollup to use ultra rollup honk flavor
lucasxia01 95326e9
add some WORKTODOs
lucasxia01 f36694a
Merge commit 'c53f4cf84c60b8d81cc62d5827ec4408da88cc4e' into lx/ipa-i…
lucasxia01 ab088af
Merge branch 'master' into lx/ipa-in-rollup
lucasxia01 c05678d
fix build
lucasxia01 f1c1e67
fix build
lucasxia01 e0a5a20
change and add some constants, account for IPA claim size in public i…
lucasxia01 d22b910
ipa claim length
lucasxia01 11f3904
fix typo of IPA_CLAIM_LENGTH
lucasxia01 8b758c9
fix avm integration test
lucasxia01 aa9c61c
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 5cbc954
update make fake proofs to use roll up honk
lucasxia01 dbecd1b
update vk generation to use ultra rollup honk
lucasxia01 010ecd8
fix to_field_elements function in ultra rollup flavor
lucasxia01 ff1971d
fix vk as fields
lucasxia01 1dfc906
updating rollup circuits to use the correct flavor of honk for recurs…
lucasxia01 bb99e16
change back to rollup honk in parity circuits
lucasxia01 d811caf
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 222d383
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 7b864df
fix build
lucasxia01 051e730
change tube to use UltraRollupFlavor
lucasxia01 7a8b90f
changes to try to split out honk and rollup honk constants
lucasxia01 399147f
fix build
lucasxia01 e41d38e
update IPA proof constant
lucasxia01 9a30580
fix build
lucasxia01 7b39066
fix build
lucasxia01 e42f50a
init grumpkin crs earlier
lucasxia01 d84209e
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 7a77731
fix build
lucasxia01 5df5cb8
fix constants
lucasxia01 2eafb7c
feat: sayonara old hints (#10547)
IlyasRidhuan 6fce0f8
fix: Bad merge on boxes (#10579)
spalladino f266e82
fix: bump hard coded SRS size for wasm from 2^19 to 2^10 (#10596)
ledwards2225 76c51f5
fix: simulation error enriching (#10595)
dbanks12 5fbf767
feat: unified create circuit from acir (#10440)
ledwards2225 e54185b
fix: temporary fix for private kernel tail proving (#10593)
LeilaWang 915c8b8
feat!: rm outgoing logs (#10486)
iAmMichaelConnor 41adcc9
chore: Tweak validator logs (#10597)
spalladino 2ada2b0
feat: metrics via terraform (#10594)
just-mitch d2259ff
chore: remove warnings from protocol circuits (#10556)
LeilaWang ed67b4c
feat: persistence in helm chart for validator and boot node (#10543)
just-mitch 9aacd97
fix: remove otel collector endpoint (#10604)
just-mitch aa1f903
git subrepo push --branch=master barretenberg
AztecBot 13e5e33
chore: replace relative paths to noir-protocol-circuits
AztecBot 343a68a
git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
AztecBot 7467dda
git subrepo push --branch=master noir-projects/aztec-nr
AztecBot d79abdf
chore: Handle errors in e2e teardown to fix e2e token (#10590)
spalladino c3d9fd7
feat: Add verify proof calls to private kernels (#10533)
sirasistant a61d42f
feat: add rollup circuit sample inputs (#10608)
MirandaWood 8cad312
chore: Disable ivc integration yarn tests (#10625)
spalladino 9f4ac42
chore: bump prover agents (#10626)
just-mitch 4de8362
fix: always respect aztec image pull policy (#10617)
just-mitch db37318
chore!: l2 gas maximum is per-TX-public-portion. AVM startup gas is n…
dbanks12 225cda6
feat: AVM inserts fee write on txs with public calls (#10394)
sirasistant 49d1068
Merge remote-tracking branch 'origin/master' into lx/ultra-rollup-hon…
lucasxia01 af82ba1
ran yarn format
lucasxia01 309daf6
add todo and update vk generation
lucasxia01 40a86ec
fix formatting
lucasxia01 4fdb211
fix build
lucasxia01 2c117b1
fix build
lucasxia01 fbcc930
fix build part 3
lucasxia01 b724055
4th times the charm right
lucasxia01 0bd7c24
fix: attempt to fix flake in e2e cross chain messaging test (#10634)
dbanks12 266cb9a
chore(avm): Gas constants adjustment based on trace rows accounting (…
jeanmon a3c3d84
fix: remove auto verify in cbind ivc prove (#10627)
ledwards2225 03c84f4
chore(avm): Reduce the number of gates for fake AVM recursive verifie…
jeanmon 99708e8
feat: deploy faucet (#10580)
alexghr 92873fa
fix: memory leak in the broker (#10567)
alexghr 9737e61
chore: merge queue CI (#10629)
ludamad aaf0efc
Merge branch 'master' into lx/ultra-rollup-honk-in-rollup-attempt
lucasxia01 7b922af
Merge remote-tracking branch 'origin/lx/ultra-rollup-honk-in-rollup-a…
lucasxia01 9f5201e
fixed up things relating to the new constants for rollup honk
lucasxia01 368fa3a
attempt to fix yarn build
lucasxia01 79d177d
fix some tests
lucasxia01 2d4aa00
Merge branch 'master' into lx/ipa-in-rollup
lucasxia01 7ad955b
add dummy vk for ipa proof
lucasxia01 695b917
Merge branch 'lx/ipa-in-rollup' of github.com:AztecProtocol/aztec-pac…
lucasxia01 3235255
fix log poly length for ipa for dummy vk
lucasxia01 cde2550
try to fix vk gen
lucasxia01 65cd39c
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 e27bd79
fix build
lucasxia01 e50483c
fix wasm build hackily
lucasxia01 5c44b30
fix some yarn errors
lucasxia01 27f407e
try turning empty nested and private kernel empty to rollup honk circ…
lucasxia01 9ca4587
fix weird type error (thanks adam!!!!!!)
lucasxia01 da18a8b
fix yarn formatting
lucasxia01 16cad70
fix verify_tube
lucasxia01 f30810f
fix gates report
lucasxia01 7931884
modify honk_recursion bool so that it also supports ultrarolluphonk a…
lucasxia01 0719e83
fix -h uses
lucasxia01 ed2df60
fix one more usage of -h
lucasxia01 b849f19
fix some tests
lucasxia01 38eb12c
Merge branch 'master' into lx/ipa-in-rollup
lucasxia01 d3692ef
make ultra recursive verifier do the breakdown of proof, and upd
lucasxia01 f56fa31
Merge branch 'lx/ipa-in-rollup' of github.com:AztecProtocol/aztec-pac…
lucasxia01 4dbf50b
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 dac5484
Merge branch 'master' into lx/ipa-in-rollup
lucasxia01 0824a93
fix wasm build
lucasxia01 1e80f9c
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 bd6e4bf
Merge remote-tracking branch 'origin/lx/ipa-in-rollup' into lx/ipa-in…
lucasxia01 e619c25
try making the IPA claim more legit in dummy vk
lucasxia01 b2cd39f
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 ae2837d
new test program for ultra rollup honk verification
lucasxia01 8d4df67
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 0b21b52
change proof sizes to match master
lucasxia01 3db0fba
fix build
lucasxia01 65e9996
push the prover toml oops
lucasxia01 56c00a9
put ipa claim and agg obj in correct order in public inputs
lucasxia01 a0c992c
fix honk recursion test
lucasxia01 e002b73
fix test to not double add ipa claims
lucasxia01 8a4e3c3
fix assertion
lucasxia01 734792e
fix acir tests
lucasxia01 821dde5
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 c4c2ffb
update bootstraps
lucasxia01 8b7e3ea
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 5179487
else if to elif
lucasxia01 c689bc2
fix regex
lucasxia01 2053fd6
fix gates report
lucasxia01 68260bc
update flame graph
lucasxia01 a9c4dcb
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 1620e02
fix build
lucasxia01 314c5a2
call self reduce on ipa evaluation after accumulation
lucasxia01 7a45458
Merge branch 'master' into lx/ipa-in-rollup
lucasxia01 584d122
Merge remote-tracking branch 'origin/master' into lx/ipa-in-rollup
lucasxia01 ea7adae
clean up and add TODOs
lucasxia01 3f12ef1
remove assert
lucasxia01 9a67a82
init grumpkin crs
lucasxia01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
barretenberg/acir_tests/flows/prove_then_verify_ultra_rollup_honk.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/sh | ||
set -eux | ||
|
||
VFLAG=${VERBOSE:+-v} | ||
BFLAG="-b ./target/program.json" | ||
FLAGS="-c $CRS_PATH $VFLAG" | ||
if [ "${RECURSIVE}" = "true" ]; then | ||
FLAGS="$FLAGS --recursive" | ||
fi | ||
|
||
# Test we can perform the proof/verify flow. | ||
# This ensures we test independent pk construction through real/garbage witness data paths. | ||
$BIN prove_ultra_rollup_honk -o proof $FLAGS $BFLAG | ||
$BIN write_vk_ultra_rollup_honk -o vk $FLAGS $BFLAG | ||
$BIN verify_ultra_rollup_honk -k vk -p proof $FLAGS |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,9 @@ export BRANCH | |
# the program for which a proof will be recursively verified | ||
PROGRAM=assert_statement | ||
# the program containing the recursive verifier | ||
RECURSIVE_PROGRAM=verify_honk_proof | ||
RECURSIVE_PROGRAM=verify_rollup_honk_proof | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert back to verify_honk_proof I guess or update so that this is a parameter of the script There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just regenerate both |
||
|
||
./reset_acir_tests.sh --programs "$PROGRAM" | ||
./reset_acir_tests.sh --no-rebuild-nargo --programs "$PROGRAM" | ||
cd "acir_tests/$PROGRAM" | ||
|
||
TOML_DIR=../../../../noir/noir-repo/test_programs/execution_success/"$RECURSIVE_PROGRAM" | ||
|
@@ -31,7 +31,7 @@ if [ ! -d "$TOML_DIR" ]; then | |
fi | ||
|
||
echo "Generating recursion inputs and writing to directory $TOML_DIR" | ||
$BIN write_recursion_inputs_honk --recursive $VERBOSE -c $CRS_PATH -b ./target/program.json -o "$TOML_DIR" | ||
$BIN write_recursion_inputs_rollup_honk --recursive $VERBOSE -c $CRS_PATH -b ./target/program.json -o "$TOML_DIR" | ||
|
||
cd ../.. | ||
./reset_acir_tests.sh --programs "$RECURSIVE_PROGRAM" | ||
./reset_acir_tests.sh --no-rebuild-nargo --programs "$RECURSIVE_PROGRAM" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be deleted now that we have 1 singular prove_then_verify.sh file for plonk and honk