Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(contracts): Update Noir contracts interfaces to use addresses instead of pubkeys #1083

Merged
merged 15 commits into from
Jul 19, 2023
Merged

chore(contracts): Update Noir contracts interfaces to use addresses instead of pubkeys #1083

merged 15 commits into from
Jul 19, 2023

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Jul 14, 2023 •
edited
Loading

  • Update zk_token
  • Update non_native_token
  • Update pending_commitments
  • Update public_token
  • Update uniswap_contract
  • Test sandbox example

Fixes #1009
Fixes #1021

@spalladino spalladino requested a review from sirasistant July 14, 2023 23:54
@spalladino spalladino changed the title Update token contract interface to use addresses instead of pubkeys Update Noir contracts interfaces to use addresses instead of pubkeys Jul 14, 2023
@spalladino spalladino removed the request for review from sirasistant July 14, 2023 23:59
@spalladino spalladino changed the title Update Noir contracts interfaces to use addresses instead of pubkeys chore: Update Noir contracts interfaces to use addresses instead of pubkeys Jul 17, 2023
@spalladino spalladino force-pushed the palla/addresses-in-zk-token-contract branch 2 times, most recently from e218260 to fdab46d Compare July 18, 2023 13:21
@spalladino spalladino marked this pull request as ready for review July 18, 2023 14:56
@spalladino spalladino enabled auto-merge (squash) July 18, 2023 15:03
@spalladino spalladino changed the title chore: Update Noir contracts interfaces to use addresses instead of pubkeys chore(contracts): Update Noir contracts interfaces to use addresses instead of pubkeys Jul 18, 2023
@spalladino spalladino mentioned this pull request Jul 18, 2023
Merged
benesjan
benesjan requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the getAddress function name all looks good to me. It's a great improvement. Once you address the naming I will approve it.

yarn-project/circuits.js/src/tests/factories.ts Outdated Show resolved Hide resolved
@spalladino spalladino force-pushed the palla/addresses-in-zk-token-contract branch from 633edb6 to 5956015 Compare July 19, 2023 12:56
@spalladino spalladino merged commit 1df89fb into master Jul 19, 2023
@spalladino spalladino deleted the palla/addresses-in-zk-token-contract branch July 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

@sirasistant sirasistant Awaiting requested review from sirasistant

@PhilWindle PhilWindle Awaiting requested review from PhilWindle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@spalladino @benesjan