feat: Validate block proposal txs iteratively #10921
Open
+844
−929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
palla/sequencer-builds-until-timeout
to
master
December 22, 2024 09:36
spalladino
force-pushed
the
palla/validate-with-iterator
branch
from
3d4ccfe to
b598cf8
Compare
spalladino
force-pushed
the
palla/validate-with-iterator
branch
from
b598cf8 to
da8056a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading all txs from the p2p pool and validating them all, we now get an iterator to the p2p pool and iteratively run through them and validate them as we go. This ensures we only load and validate strictly the txs we need. This also makes it easy to enforce new block constraints such as gas limits, which we add as two new env vars.
As part of this PR, we also change the interface of validators. Since there is no point anymore in validating txs in bulk, we drop the
validateTxsmethod in favor of justvalidateTx. And since we're at it, we enrichvalidateTxto returnvalid/invalid/skipand to include the failure reason.Fixes #10869