Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): missing circuit_ tag of c++ test #1097

Merged
merged 2 commits into from
Jul 18, 2023
Merged

chore(tests): missing circuit_ tag of c++ test #1097

merged 2 commits into from
Jul 18, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 17, 2023 •
edited
Loading

Description

Very minor change. This test should not be run by CI for wasm unless and should be tagged as "circuit_" so that you can filter it out when running quick tests with gtest filter -*circuit*

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 requested review from suyash67 and jeanmon July 18, 2023 15:35
@suyash67 suyash67 merged commit 07032c4 into master Jul 18, 2023
@suyash67 suyash67 deleted the db/tag-test-as-circuit branch July 18, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyash67 suyash67 suyash67 approved these changes

@jeanmon jeanmon Awaiting requested review from jeanmon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanks12 @suyash67