Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to master of noir and acvm-simulator #1100

Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat: update to master of noir and acvm-simulator #1100

merged 2 commits into from
Jul 18, 2023

Conversation

sirasistant
Copy link
Collaborator

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

sirasistant
sirasistant commented Jul 18, 2023
View reviewed changes
yarn-project/acir-simulator/package.json
@@ -33,7 +33,7 @@
"@aztec/circuits.js": "workspace:^",
"@aztec/foundation": "workspace:^",
"@aztec/types": "workspace:^",
"acvm_js": "github:sirasistant/acvm-simulator-wasm#1e84f2b4ecf0d0a7aee37f3d8d568add711b9e93",
"acvm_js": "github:sirasistant/acvm-simulator-wasm#32f7765a9c19d6099c2a46861dec356a075ab53c",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(still not available on NPM, but its the build from latest master)

iAmMichaelConnor
iAmMichaelConnor approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@iAmMichaelConnor iAmMichaelConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might not be the best person to review. But the changes look sensible, and if the tests pass...

@sirasistant sirasistant merged commit 8411180 into master Jul 18, 2023
@sirasistant sirasistant deleted the arv/latest_simulator_master branch July 18, 2023 11:42
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iAmMichaelConnor iAmMichaelConnor iAmMichaelConnor approved these changes

@LeilaWang LeilaWang LeilaWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @LeilaWang @iAmMichaelConnor