Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve kernel and rollup errors #1104

Merged
merged 2 commits into from
Jul 19, 2023
Merged

improve kernel and rollup errors #1104

merged 2 commits into from
Jul 19, 2023

Conversation

rahul-kothari
Copy link
Contributor

@rahul-kothari rahul-kothari commented Jul 18, 2023 •
edited
Loading

Description

Please review the error messages carefully and lmk if they don't make sense from an external POV
Closes #1101
Part of #1102 - need to update TS but that is best done in a separate PR!

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@rahul-kothari rahul-kothari force-pushed the rk/errors branch 2 times, most recently from 5f321ab to 8bb1a45 Compare July 18, 2023 15:10
dbanks12
dbanks12 requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Looks mostly good to me! Requested some fairly minor changes.

circuits/cpp/src/aztec3/utils/array.hpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.test.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp Outdated Show resolved Hide resolved
@rahul-kothari rahul-kothari requested a review from dbanks12 July 19, 2023 08:24
dbanks12
dbanks12 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great work

@rahul-kothari rahul-kothari merged commit bd52b83 into master Jul 19, 2023
@rahul-kothari rahul-kothari deleted the rk/errors branch July 19, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

@iAmMichaelConnor iAmMichaelConnor Awaiting requested review from iAmMichaelConnor

@jeanmon jeanmon Awaiting requested review from jeanmon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error messages on C++
2 participants
@rahul-kothari @dbanks12