Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): add tests that you can nullify pending notes #1109

Merged
merged 6 commits into from
Jul 19, 2023
Merged

chore(tests): add tests that you can nullify pending notes #1109

merged 6 commits into from
Jul 19, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 18, 2023 •
edited
Loading

Description

Closes #920

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 changed the title chore(tests): can nullify pending notes (simulator and e2e tests) chore(tests): add tests that you can nullify pending notes Jul 18, 2023
@dbanks12 dbanks12 marked this pull request as ready for review July 19, 2023 12:29
@dbanks12 dbanks12 requested review from jeanmon and suyash67 July 19, 2023 13:16
jeanmon
jeanmon approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbanks12 dbanks12 merged commit f5bf2d8 into master Jul 19, 2023
@dbanks12 dbanks12 deleted the db/920-e2e-nullify-pending-commitments branch July 19, 2023 16:06
@dbanks12 dbanks12 mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon approved these changes

@suyash67 suyash67 Awaiting requested review from suyash67

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aztec Noir functions should be able to nullify pending commitments from list maintained in ACIR Simulator
2 participants
@dbanks12 @jeanmon