Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable custom nargo path in compile script #1113

Merged
merged 3 commits into from
Jul 20, 2023
Merged

enable custom nargo path in compile script #1113

merged 3 commits into from
Jul 20, 2023

Conversation

iAmMichaelConnor
Copy link
Contributor

Description

I've been using nargo from source to compile noir contracts. This allows a path to nargo to be used, instead of expecting nargo to be installed properly.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

spalladino
spalladino approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some nice bash-fu!

@iAmMichaelConnor iAmMichaelConnor force-pushed the mc/noir-contract-compile-script branch from e4d0ebe to 86f5c9b Compare July 20, 2023 10:22
@iAmMichaelConnor iAmMichaelConnor enabled auto-merge (squash) July 20, 2023 10:23
@iAmMichaelConnor iAmMichaelConnor force-pushed the mc/noir-contract-compile-script branch from 86f5c9b to 6f56fd7 Compare July 20, 2023 21:49
@iAmMichaelConnor iAmMichaelConnor merged commit 3ae10ad into master Jul 20, 2023
@iAmMichaelConnor iAmMichaelConnor deleted the mc/noir-contract-compile-script branch July 20, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

@sirasistant sirasistant Awaiting requested review from sirasistant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iAmMichaelConnor @spalladino