Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): fix readme code requirements as called out in ticket #488 #1121

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore(docs): fix readme code requirements as called out in ticket #488 #1121

merged 1 commit into from
Jul 19, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 19, 2023 •
edited
Loading

Description

Closes #488

minor doc fix as requested in #488

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 requested a review from ludamad July 19, 2023 20:05
ludamad
ludamad approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally reviewed as bot : D

@dbanks12 dbanks12 requested review from suyash67 and jeanmon July 19, 2023 20:24
@dbanks12 dbanks12 closed this Jul 19, 2023
@dbanks12 dbanks12 reopened this Jul 19, 2023
@dbanks12
Copy link
Collaborator Author

Accidentally reviewed as bot : D

Are you a bot?

@dbanks12 dbanks12 merged commit 12044b4 into master Jul 19, 2023
@dbanks12 dbanks12 deleted the db/488-readme-fix branch July 19, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AztecBot AztecBot AztecBot approved these changes

@ludamad ludamad ludamad approved these changes

@suyash67 suyash67 Awaiting requested review from suyash67

@jeanmon jeanmon Awaiting requested review from jeanmon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpp code requirements in readme
3 participants
@dbanks12 @ludamad @AztecBot