Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lodash as dependency of aztec.js #1135

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Add lodash as dependency of aztec.js #1135

merged 3 commits into from
Jul 21, 2023

Conversation

PhilWindle
Copy link
Collaborator

@PhilWindle PhilWindle commented Jul 21, 2023

Description

This PR specifies a missing dependency for aztec.js

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@PhilWindle PhilWindle marked this pull request as ready for review July 21, 2023 14:23
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch!

@@ -3237,7 +3239,7 @@ __metadata:
languageName: node
linkType: hard

"@types/lodash.partition@npm:^4.6.7":
"@types/lodash.partition@npm:^4.6.0, @types/lodash.partition@npm:^4.6.7":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to use the same version across all packages, but no big deal.

@PhilWindle PhilWindle enabled auto-merge (squash) July 21, 2023 14:41
@PhilWindle PhilWindle merged commit f19e466 into master Jul 21, 2023
@PhilWindle PhilWindle deleted the pw/import-lodash branch July 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants