test(e2e): multiple accounts, same encryption key #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
changed the title
benesjan
force-pushed
the
janb/multiple-accounts-same-encryption-key
branch
from
a1ba34d to
39608d3
Compare
spalladino
approved these changes
Jul 24, 2023
| abi: ContractAbi, | ||
| args: any[], | ||
| encryptionPrivateKey: Buffer, | ||
| useProperKey: boolean, |
There was a problem hiding this comment.
This parameter is very specific to the account contract e2e tests. I'm fine keeping it in the extracted util for now, but we should rethink this interface later.
Comment on lines
90
to
94
| // First wait until the corresponding RPC server has synchronised the account | ||
| const isUserSynchronised = async () => { | ||
| return await wallet.isAccountSynchronised(owner); | ||
| }; | ||
| await retryUntil(isUserSynchronised, owner.toString(), 5); |
There was a problem hiding this comment.
Curious if we actually need this, since we only have 1 rpc server on this test
There was a problem hiding this comment.
I looked into the code and it really doesn't seem to be needed here because when tx is mined it is ensured that all the notes were already processed. I removed the check in 0b4aa5a. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1061
Checklist: