Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noir contract cleanup and small fixes. #1138

Merged
merged 8 commits into from
Jul 22, 2023
Merged

Noir contract cleanup and small fixes. #1138

merged 8 commits into from
Jul 22, 2023

Conversation

LeilaWang
Copy link
Collaborator

@LeilaWang LeilaWang commented Jul 21, 2023

Description

  • Do not assume the order of new commitments will be the same as logs => Compare all note hashes to find its nonce.
  • The read request is always correct but the nullifier could be created with the wrong value => Check the return notes from oracle have the correct contract address and storage slot.
  • Rename Set.has to Set.assert_contains.
  • Automatically nullify and create new note in Singleton.getNote.
  • Hash with index INITIALISATION_NULLIFIER.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@LeilaWang LeilaWang merged commit 58a7d82 into master Jul 22, 2023
@LeilaWang LeilaWang deleted the lw/noir_cleanup branch July 22, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants