Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using PublicKey type alias in more places #1157

Merged
merged 3 commits into from
Jul 24, 2023
Merged

refactor: using PublicKey type alias in more places #1157

merged 3 commits into from
Jul 24, 2023

Conversation

benesjan
Copy link
Contributor

Description

Fixes #1156

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan force-pushed the janb/public-key-alias-used-in-more-places branch from f1f5e6d to 5e226a9 Compare July 24, 2023 08:29
@benesjan benesjan marked this pull request as draft July 24, 2023 08:29
@benesjan benesjan marked this pull request as ready for review July 24, 2023 08:52
@benesjan benesjan enabled auto-merge (squash) July 24, 2023 09:39
spypsy
spypsy approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@spypsy spypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 👍

@benesjan benesjan merged commit 115f490 into master Jul 24, 2023
@benesjan benesjan deleted the janb/public-key-alias-used-in-more-places branch July 24, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spypsy spypsy spypsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PublicKey alias in more places
2 participants
@benesjan @spypsy