Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error docs + update ts to redirect user to these #1158

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

rahul-kothari
Copy link
Contributor

@rahul-kothari rahul-kothari commented Jul 24, 2023

Description

Closes #1102
Completes the documentation section!

  • Document all relevant errors
  • Reference solidity errors (currently we already print solidity custom errors so just needed to tell the user where to learn more about it)
  • Catch C++ errors in TS and redirect to our new errors page

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!!!!

Comment on lines +108 to +109
#### 4007 - BASE__INVALID_CHAIN_ID
The L1 chain ID you used in your proof generation (for your private transaction) is different to what the rollup circuits expected. Double check against the global variables passed to noir and the config set in [Aztec's rollup contract](https://github.com/AztecProtocol/aztec-packages/blob/master/l1-contracts/src/core/Rollup.sol) which are [read in by sequencer](https://github.com/AztecProtocol/aztec3-packages/blob/master/yarn-project/sequencer-client/src/global_variable_builder/global_builder.ts#L32) and subsequently passed in as inputs to the base rollup. When the sequencer submits the block to the rollup contracts, this is again sanity checked so ensure this is the same everywhere.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this chain ID definitely L1 chain ID? I always assumed we would track an L2 chain ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea l2 chain id is called "version" for now

@rahul-kothari rahul-kothari merged commit d4477e3 into master Jul 24, 2023
@rahul-kothari rahul-kothari deleted the rk/errors_ts_and_docs branch July 24, 2023 16:02
ludamad pushed a commit that referenced this pull request Jul 24, 2023
* add error documentation

* update c++ error try/catch + minor error touchups in archiver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Improve Error Messages
2 participants