Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): user calls a public function on a contract deployed by a different user #1159

Merged
merged 3 commits into from
Jul 24, 2023
Merged

test(e2e): user calls a public function on a contract deployed by a different user #1159

merged 3 commits into from
Jul 24, 2023

Conversation

benesjan
Copy link
Contributor

Description

Fixes #820

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan changed the title Janb/user calling another users pub func test(e2e): user calls a public function on a contract deployed by a different user Jul 24, 2023
@benesjan benesjan marked this pull request as draft July 24, 2023 10:44
@benesjan benesjan marked this pull request as ready for review July 24, 2023 11:13
@benesjan benesjan requested a review from spalladino July 24, 2023 11:13
@benesjan benesjan enabled auto-merge (squash) July 24, 2023 11:51
@benesjan benesjan force-pushed the janb/user-calling-another-users-pub-func branch from e788887 to 15ba467 Compare July 24, 2023 16:53
spalladino
spalladino approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benesjan benesjan merged commit 428b66c into master Jul 24, 2023
@benesjan benesjan deleted the janb/user-calling-another-users-pub-func branch July 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demonstrate a user calling another user's contract public function
2 participants
@benesjan @spalladino