Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(noir-contracts): necessary changes for hashing logs in Noir #1166

Merged
merged 5 commits into from
Jul 25, 2023
Merged

refactor(noir-contracts): necessary changes for hashing logs in Noir #1166

merged 5 commits into from
Jul 25, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 24, 2023 •
edited
Loading

Description

  1. Preparations for fixing Hash logs inside Noir #1165
  2. Using nicer import syntax when importing multiple constatns.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft July 24, 2023 13:17
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit bb72209
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64bf8588362f080007071f7f

@benesjan benesjan changed the title Hashing logs in Noir refactor(noir-contracts): necessary changes for hashing logs in Noir Jul 25, 2023
@benesjan benesjan marked this pull request as ready for review July 25, 2023 07:57
@benesjan benesjan force-pushed the janb/hash-logs-in-noir branch from bdd950f to 5ef7973 Compare July 25, 2023 08:02
@benesjan benesjan force-pushed the janb/hash-logs-in-noir branch from 064fded to bb72209 Compare July 25, 2023 08:19
@benesjan benesjan requested a review from spalladino July 25, 2023 08:23
@benesjan benesjan enabled auto-merge (squash) July 25, 2023 08:26
spalladino
spalladino approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benesjan benesjan merged commit f17d881 into master Jul 25, 2023
@benesjan benesjan deleted the janb/hash-logs-in-noir branch July 25, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @spalladino