Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add historic blocks tree interfaces #1168

Merged
merged 16 commits into from
Jul 26, 2023
Merged

feat: Add historic blocks tree interfaces #1168

merged 16 commits into from
Jul 26, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jul 24, 2023 •
edited
Loading

Description

closes: #1160

Adds the interfaces to handle the historic blocks roots tree, but does not add any circuit logic to check them
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 requested a review from LHerskind July 24, 2023 16:20
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit ea663c3
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c0ed5b00824300087c85a1

LHerskind
LHerskind reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

circuits/cpp/src/aztec3/circuits/abis/private_historic_tree_roots.hpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/abis/private_historic_tree_roots.hpp Outdated
@@ -20,20 +20,23 @@ template <typename NCT> struct PrivateHistoricTreeRoots {
fr nullifier_tree_root = 0;
fr contract_tree_root = 0;
fr l1_to_l2_messages_tree_root = 0;
fr historic_blocks_tree_root = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When inside the historic tree roots object, the historic here seems to be redundant, and not follow similar naming to the other values.

circuits/cpp/src/aztec3/circuits/abis/rollup/root/root_rollup_public_inputs.hpp Outdated Show resolved Hide resolved
docs/docs/aztec/how-it-works/l1-l2-messaging.md Outdated Show resolved Hide resolved
yarn-project/acir-simulator/src/client/private_execution.ts Outdated Show resolved Hide resolved
yarn-project/aztec-rpc/src/synchroniser/synchroniser.ts Outdated Show resolved Hide resolved
yarn-project/noir-libs/noir-aztec/src/abi.nr Outdated Show resolved Hide resolved
@Maddiaa0 Maddiaa0 marked this pull request as ready for review July 25, 2023 15:41
@Maddiaa0 Maddiaa0 requested a review from LHerskind July 25, 2023 17:18
@Maddiaa0 Maddiaa0 mentioned this pull request Jul 25, 2023
Merged
6 tasks
LHerskind
LHerskind approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to include the latest changes, but looks good to me 👍

@Maddiaa0 Maddiaa0 merged commit 6845c1e into master Jul 26, 2023
@Maddiaa0 Maddiaa0 deleted the md/blocks-tree-interfaces branch July 26, 2023 10:14
@spypsy
Copy link
Member

spypsy commented Jul 26, 2023

@Maddiaa0 Were these submodule folders removed on purpose here? If yes, we need to remove them from .gitmodules, otherwise add them back in the dir structure

@Maddiaa0
Copy link
Member Author

@Maddiaa0 Were these submodule folders removed on purpose here? If yes, we need to remove them from .gitmodules, otherwise add them back in the dir structure

Ah this was an accident after a merge, ill fix

@Maddiaa0 Maddiaa0 mentioned this pull request Jul 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(blocks_tree): Introduce interfaces for the blocks tree
3 participants
@Maddiaa0 @spypsy @LHerskind