Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing barretenberg .gitrepo file #1191

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: add missing barretenberg .gitrepo file #1191

merged 2 commits into from
Jul 25, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jul 25, 2023

Description

Missed this the first time around accidentally.

Checklist:

  • [*] I have reviewed my diff in github, line by line.
  • [*] Every change is related to the PR description.
  • [*] I have linked this pull request to the issue(s) that it resolves.
  • [*] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • [*] The branch has been merged or rebased against the head of its merge target.
  • [*] I'm happy for the PR to be merged at the reviewer's next convenience.

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit de77088
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c01fe92c45490008b56cc7

@ludamad ludamad requested review from dbanks12 and spalladino July 25, 2023 19:02
spalladino
spalladino approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind I'm still not very familiar with how subrepo works, but you have my 👍

@ludamad ludamad enabled auto-merge (squash) July 25, 2023 19:18
@ludamad ludamad disabled auto-merge July 25, 2023 19:27
@ludamad ludamad merged commit 11f43c4 into master Jul 25, 2023
@ludamad ludamad deleted the ad/fix/add-bb-gitrepo-file branch July 25, 2023 19:27
codygunton added a commit that referenced this pull request Jan 23, 2024
@Rumata888 @codygunton
Fixed equality operator in affine_element (#1191)
1d321fe 
* Fixed equality operator in affine_element

* Added regression test.

* Fix typo in comment.

Co-authored-by: codygunton <codygunton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

@dbanks12 dbanks12 Awaiting requested review from dbanks12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @spalladino