feat: Use unconstrained for public, view and note getter functions #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
…kages into arv/brillig_funs
sirasistant
changed the title
sirasistant
changed the title
sirasistant
commented
Jul 26, 2023
| fn arr_copy_slice<T, M>( | ||
| src: [T], | ||
| fn arr_copy_slice<T, N, M>( | ||
| src: [T; N], |
There was a problem hiding this comment.
We aren't able to freely move slices around until this noir-lang/noir#1963 is finished
ludamad
reviewed
Jul 26, 2023
| @@ -295,7 +295,7 @@ describe('Private Execution test suite', () => { | |||
| expect(newNullifiers).toEqual(consumedNotes.map(n => n.nullifier)); | |||
|
|
|||
| expect(result.preimages.newNotes).toHaveLength(2); | |||
| const [recipientNote, changeNote] = result.preimages.newNotes; | |||
There was a problem hiding this comment.
The order of the sideffects has changed. There is probably some non-determinism in the compiler if we change the point at which the functions stop being acir 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All functions marked as "should be unconstrained" and all open functions are compiled as brillig.
Checklist: