Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: try to fix #1119 #1212

Merged
merged 10 commits into from
Jul 26, 2023
Merged

ci: try to fix #1119 #1212

merged 10 commits into from
Jul 26, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jul 26, 2023 •
edited
Loading

This might help fix #1119

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
ci: debug log commands run
5a1be75 
This might help us find our culprit in checkout.
@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit 11d187f
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c15e9d918ea60008cbbf0a

@ludamad
Copy link
Collaborator Author

ludamad commented Jul 26, 2023

Well the -x doesnt REALLY need to get merged I guess. Trying stuff here.

@ludamad ludamad changed the title ci: debug log commands run ci: debug log commands run (WIP) Jul 26, 2023
@ludamad ludamad changed the title ci: debug log commands run (WIP) ci: debug log commands run Jul 26, 2023
@ludamad ludamad changed the title ci: debug log commands run ci: try to fix #1119 Jul 26, 2023
spalladino
spalladino approved these changes Jul 26, 2023
View reviewed changes
.circleci/config.yml
cd $HOME
mkdir -p .ssh
chmod 0700 .ssh
ssh-keyscan -t rsa github.com >> .ssh/known_hosts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we no longer need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do anything private. As long as we use HTTPS and not ssh or git, this seems to just work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other use of SSH in our stack I think

dbanks12
dbanks12 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludamad ludamad enabled auto-merge (squash) July 26, 2023 17:58
@ludamad ludamad merged commit 2720b22 into master Jul 26, 2023
@ludamad ludamad deleted the ad/debug-ci branch July 26, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

@spalladino spalladino spalladino approved these changes

@spypsy spypsy Awaiting requested review from spypsy

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CircleCI] Figure out intermittent failure on CircleCI
3 participants
@ludamad @spalladino @dbanks12