Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing external benchmarks #1250

Merged
merged 3 commits into from
Jul 27, 2023
Merged

fix: Fixing external benchmarks #1250

merged 3 commits into from
Jul 27, 2023

Conversation

Rumata888
Copy link
Contributor

Description

Some updates broke internal benchmarks. This fixes them

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad ludamad merged commit 79545c1 into master Jul 27, 2023
@ludamad ludamad deleted the is/fixing_benchmarks branch July 27, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees

@Rumata888 Rumata888

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rumata888 @ludamad