Run post-deployment test using deployed artifacts #1372
Conversation
PhilWindle
changed the title
There was a problem hiding this comment.
LGTM except for the tsbuildinfo file. I'd also add a check to make sure the canary is getting built with the npm version that was just published: I'm not sure if npm is eventually consistent, and if you try downloading latest immediately after publishing version N+1 there's a chance you end up getting version N.
canary/tsconfig.tsbuildinfo
Outdated
There was a problem hiding this comment.
Shouldn't this file be ignored?
| @@ -13,8 +13,7 @@ services: | |||
| - '8545:8545' | |||
|
|
|||
| sandbox: | |||
| image: $ECR_URL/aztec-sandbox:cache-$COMMIT_HASH | |||
| #image: aztecprotocol/aztec-sandbox | |||
| image: aztecprotocol/aztec-sandbox:latest | |||
There was a problem hiding this comment.
Why this change? Shouldn't we be testing an e2e with the sandbox version that corresponds to the current commit, so we ensure that any changes to sandbox are correct before we publish it?
There was a problem hiding this comment.
Oh, it's because we're tagging the current commit hash locally as latest in run_tests now, right?
| build-canary: | ||
| machine: | ||
| image: ubuntu-2004:202010-01 | ||
| resource_class: large | ||
| steps: | ||
| - *checkout | ||
| - *setup_env | ||
| - run: | ||
| name: "Build and test" | ||
| command: build canary true | ||
|
|
||
| run-canary: | ||
| docker: | ||
| - image: aztecprotocol/alpine-build-image | ||
| resource_class: small | ||
| steps: | ||
| - *checkout | ||
| - *setup_env | ||
| - run: | ||
| name: "Test" | ||
| command: spot_run_tests canary uniswap_trade_on_l1_from_l2.test.ts docker-compose.yml |
There was a problem hiding this comment.
Are these happening on every build? Or should we set them up to run only on tagged releases?
There was a problem hiding this comment.
They only run on tagged releases. The spec for that is further down the file.
canary/scripts/update_packages.sh
Outdated
| @@ -0,0 +1,10 @@ | |||
| set -e | |||
|
|
|||
| VERSION=$(npx semver $1) | |||
There was a problem hiding this comment.
Should we validate this is a valid VERSION, as we do here?
aztec-packages/build-system/scripts/deploy_npm
Lines 16 to 21 in cd78ec9
Description
This PR introduces a new
canaryapp that executes the uniswap e2e test but only using deployed artifacts. The test runs as a final step after deploying a tagged release.Checklist: